-
-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for orphaned tree files in stache:doctor command #3902
Check for orphaned tree files in stache:doctor command #3902
Conversation
Unless I'm mistaken, having a tree file without a corresponding collection doesn't hurt anything. It looks more like you get an error when there is a tree file for a collection that exists, when the tree probably shouldn't exist. Your other PR addresses this. 👍 |
Yeah definitely a mistake here, a ghost tree file gets you quite stuck. You won't be able to warm or refresh the stache again until you find the problem and remove the file. Which is hard when you don't know what you're looking for. Speaking from experience here 😅 Just drop a |
PS It was actually a bit of a challenge to write this code in a way that wouldn’t trigger the error. |
I still get an error the first time I run the command. If this is just to track down the cause of an error because there's a file that exists when it shouldn't... I don't think this is really necessary. The other PR where you fix the orphan files is the fix. The problem will just go away after that. Or, we could additionally make the store ignore any trees that don't have corresponding collections. |
I've run into this error as well. It's tricky to see the issue...this would be great! |
I don't think this command is needed. Once #3889 is done, the problem will eventually die out. |
That would be great. Working on a PR for it. No need for the doctor to check then, I agree. |
Helps with detecting the cause of #3478.
PR's #3889 and #3901 help to prevent that issue, this PR is for when the damage is already done.