Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Caching #3168

Merged
merged 31 commits into from
Jan 29, 2021
Merged

API Caching #3168

merged 31 commits into from
Jan 29, 2021

Commits on Jan 27, 2021

  1. Add default API caching config.

    @jesseleite
    jesseleite committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    3faeb6a View commit details
    Browse the repository at this point in the history

  2. Move API service provider into new API namespace.

    @jesseleite
    jesseleite committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    6cd38e2 View commit details
    Browse the repository at this point in the history

  3. Add basic API cache manager.

    @jesseleite
    jesseleite committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    23aa6d9 View commit details
    Browse the repository at this point in the history

  4. Add basic Cacher interface.

    @jesseleite
    jesseleite committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    53e04d8 View commit details
    Browse the repository at this point in the history

  5. Add dummy NullCacher.

    @jesseleite
    jesseleite committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    c6186b8 View commit details
    Browse the repository at this point in the history

  6. Implement basic DefaultCacher, with extendable AbstractCacher class.

    @jesseleite
    jesseleite committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    8013043 View commit details
    Browse the repository at this point in the history

  7. Bind API cache manager.

    @jesseleite
    jesseleite committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    a115596 View commit details
    Browse the repository at this point in the history

  8. Cache collection entries API endpoints.

    @jesseleite
    jesseleite committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    580f785 View commit details
    Browse the repository at this point in the history

  9. Fix UserSaved event firing before setting initial button options.

    @jesseleite
    jesseleite committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    83b35e3 View commit details
    Browse the repository at this point in the history

  10. Extract content events prop for reuse.

    @jesseleite
    jesseleite committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    a83b06f View commit details
    Browse the repository at this point in the history

  11. Add subcriber for handling event-based API cache invalidation.

    @jesseleite
    jesseleite committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    d7347c0 View commit details
    Browse the repository at this point in the history

  12. Handle API cache validation events.

    @jesseleite
    jesseleite committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    400082c View commit details
    Browse the repository at this point in the history

  13. Merge branch 'master' of https://github.com/statamic/cms into feature… 

    …/api-caching
    @jesseleite
    jesseleite committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    f277a46 View commit details
    Browse the repository at this point in the history

  14. Not passing in cache repository instance at the moment.

    @jesseleite
    jesseleite committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    6d97fba View commit details
    Browse the repository at this point in the history

  15. Cleanup.

    @jesseleite
    jesseleite committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    d26a6b5 View commit details
    Browse the repository at this point in the history

  16. Add basic API Cacher test case.

    @jesseleite
    jesseleite committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    e12f5e8 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2021

  1. Test configured expiry.

    @jesseleite
    jesseleite committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    cef1593 View commit details
    Browse the repository at this point in the history

  2. Ensure default API cacher converts resources to responses.

    @jesseleite
    jesseleite committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    2fe8253 View commit details
    Browse the repository at this point in the history

  3. Move response helper to parent API\AbstractCacher.

    @jesseleite
    jesseleite committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    c3bb9be View commit details
    Browse the repository at this point in the history

  4. Reverting.

    @jesseleite
    jesseleite committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    49adf88 View commit details
    Browse the repository at this point in the history

  5. Use wrapper method for getting the response

    @jasonvarga
    jasonvarga committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    237543c View commit details
    Browse the repository at this point in the history

  6. Extract helper for getting common query params.

    @jesseleite
    jesseleite committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    05a54a6 View commit details
    Browse the repository at this point in the history

  7. We already have the request here.

    @jesseleite
    jesseleite committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    e777ae4 View commit details
    Browse the repository at this point in the history

  8. Docblock.

    @jesseleite
    jesseleite committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    1c917b9 View commit details
    Browse the repository at this point in the history

  9. Wrap all API endpoints withCache().

    @jesseleite
    jesseleite committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    5e0569e View commit details
    Browse the repository at this point in the history

  10. Pass tests again. 

    Since our controllers are constructed with a request, testing multiple endpoints in a single test method will only use the first request.
    @jesseleite
    jesseleite committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    1b1c508 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2021

  1. Avoid injecting request into controllers. 

    This makes it harder to test multiple endpoints in an orchest test, as only the first request will be used when the router instantiates controllers.
    @jesseleite
    jesseleite committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    87356b2 View commit details
    Browse the repository at this point in the history

  2. Subscribe within boot

    @jasonvarga
    jasonvarga committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    ebc029d View commit details
    Browse the repository at this point in the history

  3. Cache 404s

    @jasonvarga
    jasonvarga committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    4f2cf9b View commit details
    Browse the repository at this point in the history

  4. Refactor to a middleware

    @jasonvarga
    jasonvarga committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    e963600 View commit details
    Browse the repository at this point in the history

  5. Unwrap controller responses

    @jasonvarga
    jasonvarga committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    41d7244 View commit details
    Browse the repository at this point in the history