Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make is_url modifier work with linked entries #2740

Closed
wants to merge 1 commit into from
Closed

Make is_url modifier work with linked entries #2740

wants to merge 1 commit into from

Conversation

aerni
Copy link
Contributor

@aerni aerni commented Oct 26, 2020

This PR fixes #2739. The is_url modifier now returns true on strings that start with http://, https://, and /.

@aerni
Make modifier work with linked entries
0422852 
The modifier now returns true on strings that start with `http://`, `https://`, and `/`.
@jasonvarga jasonvarga mentioned this pull request Oct 28, 2020
Merged
@jasonvarga
Copy link
Member

Closing in favor of #2759

With your change alone, it would break a couple of cases. mailto:[email protected] and ftp://something.com were both considered urls by the is_url modifier. I've moved the logic in there. Figured it was easier to just do it than explain what to do. No hard feelings!

@aerni
Copy link
Contributor Author

aerni commented Oct 28, 2020

Sweet! Thanks for looking at it.

@aerni aerni closed this Oct 28, 2020
@aerni aerni deleted the is-url branch October 29, 2020 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

is_url Modifier returns false on entry
2 participants
@aerni @jasonvarga