Localize the parent tag

[daiwai]

Fetch the parent data from the current site/locale.

Updated the Entry::findByUri @method signature to include the $site parameter

Also, URL::removeSiteUrl() adds a superfluous slash and should probably call URL::tidy() before returning. I did not change removeSiteUrl in this PR yet, because I wanted to confirm whether the current behavior is intentional (as far as I see, that method is not covered by a test).

[jasonvarga]

This is great, thanks.

I don't think it fixes the issue you've linked to, but it does fix the tag 👍

[daiwai]

Thanks for the review and merging!

I don't think it fixes the issue you've linked to, but it does fix the tag

Well, I referenced the linked issue because of your #2991 (comment) there, and you changing the title of that issue to "The parent tag doesn't localize" which this PR addressed.

But you are right that this doesn't do anything related to the issue with non-localized relations not being automatically loaded in the current site locale which is also mentioned in #2991

Also, URL::removeSiteUrl() adds a superfluous slash and should probably call URL::tidy() before returning. I did not change removeSiteUrl in this PR yet, because I wanted to confirm whether the current behavior is intentional (as far as I see, that method is not covered by a test).

I see you used Str::after() instead of URL::removeSiteUrl() any thoughts on the current behavior of removeSiteUrl() though?

[jasonvarga]

That method isn't used anywhere throughout the code base. I think it's just there for backwards compatibility at this point, in case someone else happens to be using it. I don't want to touch it.

Also, it looks like I misunderstood that issue initially, the title I changed it to is wrong.