Add option to set custom path to git binary #3393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems fine to me. Are you planning to add anything else? You still have this PR marked as a draft. Feel free to switch it over if you're done. |
|
Nope, that's all for this PR :) I am not sure if the code comment is good enough linguistically (because the config will be copied to the users repository), but if is, then I am happy with it, too ;) |
|
Thanks, that comment makes more sense 🎉 |
|
Works great, lovely! Thank you for PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3392
This is an idea to fix #3392 by making the path to the git binary configurable for a case where the
gitcommand is not directly available in the environment. Sorry for my bad english in the code comment 🙈