Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(minor) Fieldtypes (Array and similar): inconsistencies in KEYS and LABELS leading to translation differences #3130

Closed
ebeauchamps opened this issue Jan 19, 2021 · 0 comments · Fixed by #4458

Comments

@ebeauchamps
Copy link
Contributor

ebeauchamps commented Jan 19, 2021

Bug Description

Related to commit ac18e9c
Related to issue #2515

The above commit has introduced the possibility to translate the "Optional" key for the Label heading of the ARRAY fieldtype:
Capture d’écran 2021-01-19 à 22 21 17

This is now OK.

I was expecting to find the same behaviour in similar fieldtypes, but I am not. I am even still getting English strings.
CHECKBOXES:
Capture d’écran 2021-01-19 à 22 22 42

I get "KEY (VALUE)" instead of "CLE"?
I am missing the (optional) string, too.
And as you can perhaps see the sentence above the grid of KEYS and VALUES isn't exactly the same (in English as in French)

BUTTON GROUP, RADIO, SELECT, :
Missing the (Optional) string: I only get KEY and LABEL (Clé and Etiquette in French)
(Optional) should be added.

How to Reproduce

Add an ARRAY fieldtype and similar fieldtypes in a fieldset.

Statamic version: 3.0.39

PHP version: 7.4.2

Install method (choose one):

  • Fresh install from statamic/statamic
@ebeauchamps ebeauchamps changed the title [i18n] Fieldtypes (array and similar): inconsistencies in in KEYS and LABELS (minor) (minor) Fieldtypes (Array and similar): inconsistencies in KEYS and LABELS leading to translation differences Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants