Partial tag subdirectory code incorrect

[ellukesmith]

Bug Description

The partials tag allows you to specify a path, but it also contains code to automatically load anything in the 'partials' directory if not found. This code is currently incorrect, as it replaces slashes with a period, but doesn't convert back to slashes when checking the partials directory.

How to Reproduce

Try to include a file in the partials directory without including the 'partials' dir in the include.
{{ partial:partial_name }}

Extra Detail

The screenshot below shows the line 31 in the Partial tag file checking if 'partials.'.$partial exists, but it needs to run it through underscoredViewName, otherwise it doesn't add the slash back in.

Environment

Statamic 3.0.30 Pro
Laravel 8.15.0
PHP 7.3.24

Install method (choose one):

• Fresh install from statamic/statamic

[jasonvarga]

It seems to work fine. I can't see a problem with the code. Can you provide any more details?

[ellukesmith]

I think the wording in the docs threw me off here.

The docs recommend to put an underscore before each partial, so my assumption was this would also apply even if storing the partials in a partials directory. The current code doesn't work if the files in a partials directory start with an underscore.

Is the expected behaviour that partials in a partials dir don't start with an underscore? If so, it probably just needs a note added to the docs about this.

[robdekort]

Hey the docs state that the views need to be prefixed. In the example I don't see it saying the folders need an underscore. Let me know where it throws you off and I'll PR the docs to make it more clear.

[jasonvarga]

See statamic/ideas#305 where exactly this has been requested.