Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FormSubmitted has 'form' instead of 'submission' as data name #2271

Closed
edalzell opened this issue Aug 22, 2020 · 2 comments
Closed

FormSubmitted has 'form' instead of 'submission' as data name #2271

edalzell opened this issue Aug 22, 2020 · 2 comments

Comments

@edalzell
Copy link
Contributor

Bug Description

The FormSubmitted event has a form property. However a submission is passed to it:

(FormSubmitted::dispatch($submission)

The submission is correct, I believe the property should be $submission, not form.

Statamic version: 3.0.0

PHP version: 7.4
@aryehraber
Copy link
Contributor

Yeah, I felt this was a little odd/unintuitive too but just went with it in Captcha: https://github.com/aryehraber/statamic-captcha/blob/master/src/Listeners/ValidateFormSubmission.php#L22

Please give some warning if this gets changed so that I can update in the addon.

@jasonvarga
Copy link
Member

🤦

@aryehraber aryehraber mentioned this issue Aug 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jasonvarga @aryehraber @edalzell