Glide does handle unsupported file formats. #2122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Glide is a great tool to resize images, but can't handle some file formats like SVG files. It does make sense. Why would you want to resize a SVG image?
This PR does make it possible to pass any kind of image to glide. Should a specific format be not supported, glide will return the original path and the image would be shown in every case.
A common use case will make this more clear.
```
// Instead of
{{ customers }}
{{ if logo:extension !== "svg" }}
<img src="{{ glide:logo width='165' quality='100' }}">
{{ else }}
<img src="{{ logo }}">
{{ /if }}
{{ /customers }}
// You can do
{{ customers }}
<img src="{{ glide:logo width='165' quality='100' }}">
{{ /customers }}
```
jonassiewertsen
changed the title
added 2 commits
July 22, 2020 21:04
|
This is probably one of the most useful enhancements that V3 is missing right now ❤️ |
jasonvarga
added a commit
that referenced
this pull request
Sep 7, 2020
Co-authored-by: Jonas Siewertsen <[email protected]>
|
Merged via 8a9f445, thanks Jonas! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Glide is a great tool to resize images, but can't handle some file formats like SVG files. It does make sense. Why would you want to resize a SVG image?
This PR does make it possible to pass any kind of image to glide. Should a specific format be not supported, glide will return the original path and the image would be shown in every case.
A common use case will make this more clear.
Until now you would check if fx an SVG is among the images.
The same result if this PR gets approved
The SVG format is not supported, so the original path would be returned.
@jasonvarga I am not sure about the Exception.