Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmd-S not tied to Save on Navigation CP #1794

Closed
edalzell opened this issue May 5, 2020 · 3 comments · Fixed by #2873
Closed

Cmd-S not tied to Save on Navigation CP #1794

edalzell opened this issue May 5, 2020 · 3 comments · Fixed by #2873

Comments

@edalzell
Copy link
Contributor

edalzell commented May 5, 2020

Bug Description

If you're on the Navigation screen and you have changes and hit cmd-s (like you can do on entries), you don't save the data, you get the browser save.

How to Reproduce

  1. Make a navigation
  2. Add an item
  3. cmd-s

Environment

Statamic version: 3.0.0-beta-27

PHP version: 7.4

Install method (choose one):

  • Fresh install from statamic/statamic
@jackmcdade jackmcdade added the bug label May 11, 2020
@jackmcdade
Copy link
Member

jackmcdade commented May 11, 2020

Confirmed. You must add an item to recreate the issue - simply rearranging the nav doesn't cause issue.

@jackmcdade
Copy link
Member

Can't quite find the fix on this one, but it's only happening when you add a URL, not a link.

@arthurperton
Copy link
Contributor

Hu guys, I looked into this one. The problem is that the included PageEditor component is stopping the events necessary for the keyboard shortcuts to work. The code in PageEditor could be improved to avoid that. I'll create a PR with the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants