-
-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Manage publish state" permission not working #1011
Comments
I just set up the exact same thing, since I will need it for a project. I can confirm, that the user can manage the publish state, which he shouldn't. |
Yes I have this problem too! And at the page list can sort pages. |
I hope this gets fixed in a future release! |
It cannot be fixed in a previous release! |
Therefore it must be fixed in a future release…or the current. |
Wanna fight?! 4pm in the backjard of your school. 1 vs 1. |
I bring my bike crib gang.. |
The same bug seems to apply to creating/publishing revisions, and deleting entries. |
The logic seems to work when revisions are enabled, though there are some UX issues: the user without the publish permission sees the "publish" button, but a click on it returns "error: request failed with status 403" and the entry is (correctly) not published. The user with publish rights can publish afterwards. Also the revision's author is changed to the publishing user, I'm not sure if that is intended?
To sum it up, the publish feature with the permissions works fine if revisions are enabled (just the publish button is displayed when it shouldnt). So maybe just the docs have to be updated? |
I've created a pull request which will set the published toggle to be read only if a user doesn't have the correct set of permissions. #3039 |
I created a test user with a role that disallows managing publish states. E.g. for authors that only are able to create stuff, but not publish it before a proofreader approves this. I unchecked the "Manage publish state" option but still, I am able as the user to publish entries.
The resources/users/roles.yaml:
The text was updated successfully, but these errors were encountered: