Skip to content

Commit

Permalink
fix(checkbox): checkbox throws error if no label #135
Browse files Browse the repository at this point in the history
do register on ripple interaction listeners on wrapper vs root and label

fixes #135
  • Loading branch information
stasson committed Nov 30, 2017
1 parent bd700bf commit c3e7c97
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions components/checkbox/mdc-checkbox.vue
Original file line number Diff line number Diff line change
Expand Up @@ -92,14 +92,6 @@ export default {
this.ripple = new RippleBase(this, {
isUnbounded: () => true,
isSurfaceActive: () => RippleBase.isSurfaceActive(this.$refs.control),
registerInteractionHandler: (evt, handler) => {
this.$refs.root.addEventListener(evt, handler)
this.$refs.label.addEventListener(evt, handler)
},
deregisterInteractionHandler: (evt, handler) => {
this.$refs.root.removeEventListener(evt, handler)
this.$refs.label.removeEventListener(evt, handler)
},
computeBoundingRect: () => {
const {left, top} = this.$refs.control.getBoundingClientRect()
const DIM = 40
Expand Down

0 comments on commit c3e7c97

Please sign in to comment.