fix(card): action button should render a <button> tag

stasson · Sep 30, 2017 · 30e7f25 · 30e7f25
1 parent d975a18
commit 30e7f25
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 19 deletions.
diff --git a/components/card/README.md b/components/card/README.md
@@ -99,7 +99,6 @@ container:
 
 | props | Type | Default | Description |
 |-------|------|---------|-------------|
-|`href`| String |optional| sets button's link |
 |`disabled`| boolean |false| wether the button is disabled |
 
 ```html
@@ -110,16 +109,6 @@ container:
 </mdc-card>
 ```
 
-Actions Buttons can also be links specifying the href property
-
-```html
-<mdc-card>
-  <mdc-card-actions>
-    <mdc-card-action-button href="#">Link</mdc-card-action-button>
-  </mdc-card-actions>
-</mdc-card>
-```
-
 ### Horizontal block
 
 You can stack multiple card blocks horizontally instead of vertically, by 

diff --git a/components/card/mdc-card-action-button.vue b/components/card/mdc-card-action-button.vue
@@ -1,11 +1,9 @@
 <template>
-  <a :href="disabled?undefined:href" >
-    <button ref="root" class="mdc-card-action-button"
-      :class="classes" :style="styles" :disabled="disabled" 
-      @click="$emit('click')">
-      <slot />
-    </button>
-  </a>
+  <button ref="root" class="mdc-card-action-button"
+    :class="classes" :style="styles" :disabled="disabled" 
+    @click="$emit('click')">
+    <slot />
+  </button>
 </template>
 
 <script lang="babel">
@@ -14,7 +12,6 @@ import {RippleBase} from '../util'
 export default {
   name: 'mdc-card-action-button',
   props: {
-    href: String,
     disabled: Boolean
   },
   data () {