Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make database ready timeout configurable in Function level #765

Closed
hossainemruz opened this issue May 3, 2019 · 1 comment
Closed

Make database ready timeout configurable in Function level #765

hossainemruz opened this issue May 3, 2019 · 1 comment
Labels
api/v1beta1 enhancement
Milestone
0.9.0

Comments

@hossainemruz
Copy link
Contributor

Different database may need different time to be ready. Currently we wait 30 sec for database to be ready.

stash/pkg/cmds/backup_pg.go

Line 177 in 09af5d3

func waitForDBReady(host string, port int32) {

This is not enough. We should make it configurable via flag. Default value could be 15 min.
@hossainemruz hossainemruz added this to the 0.9.0 milestone May 3, 2019
@tamalsaha tamalsaha modified the milestone: 0.9.0 May 7, 2019
@hossainemruz
Copy link
Contributor Author

Done for the all available addons. ref: stashed/project#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api/v1beta1 enhancement
Projects
None yet
Milestone
0.9.0
Development

No branches or pull requests
2 participants
@tamalsaha @hossainemruz