Remove creationTimestamp from PartialObjectMeta (#1006)

* Remove creationTimestamp from PartialObjectMeta Signed-off-by: Tamal Saha <[email protected]> * Fix tests Signed-off-by: Tamal Saha <[email protected]>
stashed · Jan 4, 2020 · d6e0fe4 · d6e0fe4
1 parent 6ae7913
commit d6e0fe4
Show file tree

Hide file tree

Showing 60 changed files with 633 additions and 11,175 deletions.
diff --git a/api/crds/bindata.go b/api/crds/bindata.go
diff --git a/api/crds/stash.appscode.com_backupbatches.yaml b/api/crds/stash.appscode.com_backupbatches.yaml
@@ -701,16 +701,6 @@ spec:
                               are not queryable and should be preserved when modifying
                               objects. More info: http://kubernetes.io/docs/user-guide/annotations'
                             type: object
-                          creationTimestamp:
-                            description: "CreationTimestamp is a timestamp representing
-                              the server time when this object was created. It is
-                              not guaranteed to be set in happens-before order across
-                              separate operations. Clients may not set this value.
-                              It is represented in RFC3339 form and is in UTC. \n
-                              Populated by the system. Read-only. Null for lists.
-                              More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata"
-                            format: date-time
-                            type: string
                           generateName:
                             description: "GenerateName is an optional prefix, used
                               by the server, to generate a unique name ONLY IF the

diff --git a/api/crds/stash.appscode.com_backupblueprints.yaml b/api/crds/stash.appscode.com_backupblueprints.yaml
@@ -1331,15 +1331,6 @@ spec:
                         and retrieve arbitrary metadata. They are not queryable and
                         should be preserved when modifying objects. More info: http://kubernetes.io/docs/user-guide/annotations'
                       type: object
-                    creationTimestamp:
-                      description: "CreationTimestamp is a timestamp representing
-                        the server time when this object was created. It is not guaranteed
-                        to be set in happens-before order across separate operations.
-                        Clients may not set this value. It is represented in RFC3339
-                        form and is in UTC. \n Populated by the system. Read-only.
-                        Null for lists. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata"
-                      format: date-time
-                      type: string
                     generateName:
                       description: "GenerateName is an optional prefix, used by the
                         server, to generate a unique name ONLY IF the Name field has

diff --git a/api/crds/stash.appscode.com_backupconfigurations.yaml b/api/crds/stash.appscode.com_backupconfigurations.yaml
@@ -390,15 +390,6 @@ spec:
                         and retrieve arbitrary metadata. They are not queryable and
                         should be preserved when modifying objects. More info: http://kubernetes.io/docs/user-guide/annotations'
                       type: object
-                    creationTimestamp:
-                      description: "CreationTimestamp is a timestamp representing
-                        the server time when this object was created. It is not guaranteed
-                        to be set in happens-before order across separate operations.
-                        Clients may not set this value. It is represented in RFC3339
-                        form and is in UTC. \n Populated by the system. Read-only.
-                        Null for lists. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata"
-                      format: date-time
-                      type: string
                     generateName:
                       description: "GenerateName is an optional prefix, used by the
                         server, to generate a unique name ONLY IF the Name field has

diff --git a/api/crds/stash.appscode.com_restoresessions.yaml b/api/crds/stash.appscode.com_restoresessions.yaml
@@ -381,15 +381,6 @@ spec:
                         and retrieve arbitrary metadata. They are not queryable and
                         should be preserved when modifying objects. More info: http://kubernetes.io/docs/user-guide/annotations'
                       type: object
-                    creationTimestamp:
-                      description: "CreationTimestamp is a timestamp representing
-                        the server time when this object was created. It is not guaranteed
-                        to be set in happens-before order across separate operations.
-                        Clients may not set this value. It is represented in RFC3339
-                        form and is in UTC. \n Populated by the system. Read-only.
-                        Null for lists. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata"
-                      format: date-time
-                      type: string
                     generateName:
                       description: "GenerateName is an optional prefix, used by the
                         server, to generate a unique name ONLY IF the Name field has
@@ -2393,16 +2384,6 @@ spec:
                               are not queryable and should be preserved when modifying
                               objects. More info: http://kubernetes.io/docs/user-guide/annotations'
                             type: object
-                          creationTimestamp:
-                            description: "CreationTimestamp is a timestamp representing
-                              the server time when this object was created. It is
-                              not guaranteed to be set in happens-before order across
-                              separate operations. Clients may not set this value.
-                              It is represented in RFC3339 form and is in UTC. \n
-                              Populated by the system. Read-only. Null for lists.
-                              More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata"
-                            format: date-time
-                            type: string
                           generateName:
                             description: "GenerateName is an optional prefix, used
                               by the server, to generate a unique name ONLY IF the

diff --git a/api/openapi-spec/swagger.json b/api/openapi-spec/swagger.json
@@ -14227,10 +14227,6 @@
             "type": "string"
           }
         },
-        "creationTimestamp": {
-          "description": "CreationTimestamp is a timestamp representing the server time when this object was created. It is not guaranteed to be set in happens-before order across separate operations. Clients may not set this value. It is represented in RFC3339 form and is in UTC.\n\nPopulated by the system. Read-only. Null for lists. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata",
-          "$ref": "#/definitions/io.k8s.apimachinery.pkg.apis.meta.v1.Time"
-        },
         "generateName": {
           "description": "GenerateName is an optional prefix, used by the server, to generate a unique name ONLY IF the Name field has not been provided. If this field is used, the name returned to the client will be different than the name passed. This value will also be combined with a unique suffix. The provided value has the same validation rules as the Name field, and may be truncated by the length of the suffix required to make the value unique on the server.\n\nIf this field is specified and the generated name exists, the server will NOT return a 409 - instead, it will either return 201 Created or 500 with Reason ServerTimeout indicating a unique name could not be found in the time allotted, and the client should retry (optionally after the time indicated in the Retry-After header).\n\nApplied only if Name is not specified. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#idempotency",
           "type": "string"

diff --git a/apis/repositories/v1alpha1/openapi_generated.go b/apis/repositories/v1alpha1/openapi_generated.go
diff --git a/apis/stash/v1alpha1/openapi_generated.go b/apis/stash/v1alpha1/openapi_generated.go
diff --git a/apis/stash/v1beta1/openapi_generated.go b/apis/stash/v1beta1/openapi_generated.go
diff --git a/go.mod b/go.mod
@@ -37,12 +37,12 @@ require (
 	k8s.io/kube-aggregator v0.0.0-20191114103820-f023614fb9ea
 	k8s.io/kube-openapi v0.0.0-20191107075043-30be4d16710a
 	k8s.io/kubernetes v1.16.3
-	kmodules.xyz/client-go v0.0.0-20191219184245-880ab4b0e5db
+	kmodules.xyz/client-go v0.0.0-20200101081724-6b136a38d486
 	kmodules.xyz/constants v0.0.0-20191024095500-cd4313df4aa6
 	kmodules.xyz/crd-schema-fuzz v0.0.0-20191129174258-81f984340891
 	kmodules.xyz/custom-resources v0.0.0-20191130062942-f41b54f62419
 	kmodules.xyz/objectstore-api v0.0.0-20191127144749-5881939b57f0
-	kmodules.xyz/offshoot-api v0.0.0-20191204032627-ee9a85c51ab3
+	kmodules.xyz/offshoot-api v0.0.0-20200103145223-2c4f520520d2
 	kmodules.xyz/openshift v0.0.0-20191127145035-f6c48a90dbb7
 	kmodules.xyz/prober v0.0.0-20191216013129-7c91e2b0edb2
 	kmodules.xyz/webhook-runtime v0.0.0-20191127075323-d4bfdee6974d

diff --git a/go.sum b/go.sum
@@ -689,8 +689,8 @@ k8s.io/utils v0.0.0-20190801114015-581e00157fb1 h1:+ySTxfHnfzZb9ys375PXNlLhkJPLK
 k8s.io/utils v0.0.0-20190801114015-581e00157fb1/go.mod h1:sZAwmy6armz5eXlNoLmJcl4F1QuKu7sr+mFQ0byX7Ew=
 kmodules.xyz/client-go v0.0.0-20191127054604-26981530831d/go.mod h1:OFxuKCiVR+MYlR2a08FkfaF+IbXkLe0xBetu2LTUuGI=
 kmodules.xyz/client-go v0.0.0-20191211192817-f1dcd02124ba/go.mod h1:OFxuKCiVR+MYlR2a08FkfaF+IbXkLe0xBetu2LTUuGI=
-kmodules.xyz/client-go v0.0.0-20191219184245-880ab4b0e5db h1:6ucciOzNh6nKC5uN3DetZ/rLtp/mgc3SfFSFL+sZEX0=
-kmodules.xyz/client-go v0.0.0-20191219184245-880ab4b0e5db/go.mod h1:OFxuKCiVR+MYlR2a08FkfaF+IbXkLe0xBetu2LTUuGI=
+kmodules.xyz/client-go v0.0.0-20200101081724-6b136a38d486 h1:6Oa0APtijqhcZ1NCjrX0Uegm/GyyAcHopIR0EIORZsc=
+kmodules.xyz/client-go v0.0.0-20200101081724-6b136a38d486/go.mod h1:OFxuKCiVR+MYlR2a08FkfaF+IbXkLe0xBetu2LTUuGI=
 kmodules.xyz/constants v0.0.0-20191024095500-cd4313df4aa6 h1:hFv3DzanQJ/bjgahqosmthGLkVgMB2KuQIsltOA02t0=
 kmodules.xyz/constants v0.0.0-20191024095500-cd4313df4aa6/go.mod h1:DbiFk1bJ1KEO94t1SlAn7tzc+Zz95rSXgyUKa2nzPmY=
 kmodules.xyz/crd-schema-fuzz v0.0.0-20191129174258-81f984340891 h1:2W/fqLbAurvupIZL3TEFrlb7DnOIhlOXpNgzgcFFSmA=
@@ -699,8 +699,8 @@ kmodules.xyz/custom-resources v0.0.0-20191130062942-f41b54f62419 h1:o6KD8XMxdyRR
 kmodules.xyz/custom-resources v0.0.0-20191130062942-f41b54f62419/go.mod h1:EksiAQK3p3bVU5cNBjLT0z5V7er1tvWLBWILTuf6G/0=
 kmodules.xyz/objectstore-api v0.0.0-20191127144749-5881939b57f0 h1:ilgkGU/bteKRvH99piXxU8b2c1E9lwxb0sDpLLhy4iY=
 kmodules.xyz/objectstore-api v0.0.0-20191127144749-5881939b57f0/go.mod h1:AE1rz+T/3dlUwH5pLgCNghWeeFfeVBnBXKJVpsLHlmc=
-kmodules.xyz/offshoot-api v0.0.0-20191204032627-ee9a85c51ab3 h1:DW3lX0hZzx14WTNCU+RTWU2eKZ4xbKpUvYVy6S5OtBc=
-kmodules.xyz/offshoot-api v0.0.0-20191204032627-ee9a85c51ab3/go.mod h1:k1M+OOFHbMeS6N6OB2j9smKfMCyQOEQjZ3SLZ/KSe+w=
+kmodules.xyz/offshoot-api v0.0.0-20200103145223-2c4f520520d2 h1:c/wxNy8KgaS8v/htruqtL0YgrKciUKroK1zXPVZHuqg=
+kmodules.xyz/offshoot-api v0.0.0-20200103145223-2c4f520520d2/go.mod h1:k1M+OOFHbMeS6N6OB2j9smKfMCyQOEQjZ3SLZ/KSe+w=
 kmodules.xyz/openshift v0.0.0-20191127054841-113eeb13704f/go.mod h1:de9+Zk2+wtGhRmGFBZ9T4+0lJZr4rHXW0dHffCaeO+g=
 kmodules.xyz/openshift v0.0.0-20191127145035-f6c48a90dbb7 h1:9PImU28r8bt+QoW7FkYbJ+prsZSNtwctLeXJj3wJK5U=
 kmodules.xyz/openshift v0.0.0-20191127145035-f6c48a90dbb7/go.mod h1:de9+Zk2+wtGhRmGFBZ9T4+0lJZr4rHXW0dHffCaeO+g=

diff --git a/test/e2e/e2e_suite_test.go b/test/e2e/e2e_suite_test.go
@@ -32,7 +32,7 @@ import (
 	_ "stash.appscode.dev/stash/test/e2e/backupbatch"
 	"stash.appscode.dev/stash/test/e2e/framework"
 	_ "stash.appscode.dev/stash/test/e2e/hooks"
-	_ "stash.appscode.dev/stash/test/e2e/miscellaneous-use-cases"
+	_ "stash.appscode.dev/stash/test/e2e/misc"
 	_ "stash.appscode.dev/stash/test/e2e/volumes"
 	_ "stash.appscode.dev/stash/test/e2e/workloads"
 

diff --git a/.../e2e/miscellaneous-use-cases/clone_pvc.go → test/e2e/misc/clone_pvc.go b/.../e2e/miscellaneous-use-cases/clone_pvc.go → test/e2e/misc/clone_pvc.go
@@ -13,11 +13,10 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 See the License for the specific language governing permissions and
 limitations under the License.
 */
-package miscellaneous_use_cases
+package misc
 
 import (
 	"fmt"
-	"time"
 
 	"stash.appscode.dev/stash/apis"
 	"stash.appscode.dev/stash/apis/stash/v1beta1"
@@ -91,9 +90,6 @@ var _ = Describe("Clone", func() {
 							PartialObjectMeta: ofst.PartialObjectMeta{
 								Name:      restoredPVCName,
 								Namespace: f.Namespace(),
-								CreationTimestamp: metav1.Time{
-									Time: time.Now(),
-								},
 							},
 							Spec: core.PersistentVolumeClaimSpec{
 								AccessModes: []core.PersistentVolumeAccessMode{
@@ -172,9 +168,6 @@ var _ = Describe("Clone", func() {
 							PartialObjectMeta: ofst.PartialObjectMeta{
 								Name:      fmt.Sprintf("%s-${POD_ORDINAL}", restoredPVCNamePrefix),
 								Namespace: f.Namespace(),
-								CreationTimestamp: metav1.Time{
-									Time: time.Now(),
-								},
 							},
 							Spec: core.PersistentVolumeClaimSpec{
 								AccessModes: []core.PersistentVolumeAccessMode{

diff --git a/...e2e/miscellaneous-use-cases/repository.go → test/e2e/misc/repository.go b/...e2e/miscellaneous-use-cases/repository.go → test/e2e/misc/repository.go
@@ -13,7 +13,7 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 See the License for the specific language governing permissions and
 limitations under the License.
 */
-package miscellaneous_use_cases
+package misc
 
 import (
 	"fmt"

diff --git a/vendor/github.com/google/btree/btree_mem.go b/vendor/github.com/google/btree/btree_mem.go