Skip to content

Commit

Permalink
Disable admission controllers for webhook server (#468)
Browse files Browse the repository at this point in the history
Since [1.10 release](https://github.com/kubernetes/apiserver/blob/release-1.10/pkg/server/options/recommended.go#L43) admission options are enabled by default . This was not the case in 1.9 release. Admission plugins seem unnecessary for a webhook server. So, I am disabling it.

If this is left enabled, then RBAC permissions need to be updated accordingly.
```
- apiGroups:
  - admissionregistration.k8s.io
  resources:
    - mutatingwebhookconfigurations
    - validatingwebhookconfigurations
  verbs: ["get","list"]
```
  • Loading branch information
tamalsaha authored May 5, 2018
1 parent 2f19545 commit 120e5de
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions server/start.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ func NewStashOptions(out, errOut io.Writer) *StashOptions {
StdErr: errOut,
}
o.RecommendedOptions.Etcd = nil
o.RecommendedOptions.Admission = nil

return o
}
Expand Down

0 comments on commit 120e5de

Please sign in to comment.