Skip to content

Commit

Permalink
Remove importance of order of rule in RestoreSession (#795)
Browse files Browse the repository at this point in the history
Tasks:
- [x] Remove importance of rule order
- [x] Add validator to ensure followings,
	- [x] There is at most one rule with empty targetHosts field.
	- [x] No two rule with non-empty targetHosts matches for a host.
	- [x] If snapshot is specified in a rule then paths is not specified.
- [x] Update concept doc to make rules behavior clear

Fixes: stashed/stash#790
  • Loading branch information
hossainemruz authored and tamalsaha committed May 22, 2019
1 parent 86a4af0 commit 3f1f4cf
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions server/start.go
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ func (o StashOptions) Config() (*server.StashConfig, error) {
"/apis/admission.stash.appscode.com/v1alpha1/replicationcontrollermutators",
"/apis/admission.stash.appscode.com/v1alpha1/replicasetmutators",
"/apis/admission.stash.appscode.com/v1alpha1/deploymentconfigmutators",
"/apis/admission.stash.appscode.com/v1beta1/restoresessionvalidators",
}

extraConfig := controller.NewConfig(serverConfig.ClientConfig)
Expand Down

0 comments on commit 3f1f4cf

Please sign in to comment.