Add MSI installer #263
Merged
Add MSI installer #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binarymaster
requested changes
Jun 13, 2017
RDPWInst.wxs
Outdated
| </Directory> | ||
| </Directory> | ||
|
|
||
| <Feature Id="ProductFeature" Title="SetupProject1" Level="1"> |
There was a problem hiding this comment.
These lines looks like a template, it would be better to give them proper names
| <Wix xmlns="http://schemas.microsoft.com/wix/2006/wi"> | ||
| <?define ProductName="RDP Wrapper Library" ?> | ||
| <?define ProductVersion="1.6.1" ?> | ||
| <?define ProductCode="37ea5771-3352-4a52-9fac-9297331daebd"?> |
There was a problem hiding this comment.
Just wondering where these GUIDs came from?
There was a problem hiding this comment.
Autogenerated from https://www.guidgen.com/ as recommended by WiX Documentation.
RDPWInst.wxs
Outdated
| <Directory Id="CommonAppDataFolder"> | ||
| <Directory Id="PACKAGECACHE" Name="Package Cache"> | ||
| <Directory Id="INSTALLLOCATION" Name="{$(var.ProductCode)}"> | ||
| <Component Id="ProductComponent" Guid="affd77d1-b35c-46f3-a97f-1686dc57b8b8"> |
There was a problem hiding this comment.
Autogenerated from https://www.guidgen.com/ as recommended by WiX Documentation.
| <CustomAction Id='UninstallAction' FileKey='RDPWInst' ExeCommand='-u' Execute='immediate' Return='check'/> | ||
| <CustomAction Id='UpdateAction' FileKey='RDPWInst' ExeCommand='-w' Execute='immediate' Return='check'/> | ||
| <!-- <CustomAction Id='ChangeAction' Directory='ProgramFilesFolder' ExeCommand='RDP Wrapper\RDPConf' Execute='immediate' Return='check'/> | ||
| <CustomAction Id='RepairAction' Directory='ProgramFilesFolder' ExeCommand='RDP Wrapper\RDPCheck' Execute='immediate' Return='check'/> --> |
There was a problem hiding this comment.
For repair action, does it possible to execute RDPWInst twice to run uninstall and then install it again?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #14
For compilation install WiX Toolset.