Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script for changelog from subdirectory inforormation #96

Merged
merged 1 commit into from
Jul 15, 2014

Conversation

snozawa
Copy link
Contributor

@snozawa snozawa commented Jul 10, 2014

(create_changelog.sh) : Add script for changelog from subdirectory information
This is discussed in jsk-ros-pkg/jsk_roseus#134

However, I have one question about catkin subdirectory.
Currently, default argument is set for rosbuild environment.
In rosbuild environment, hrpsys-base-source is located in $(rospack find hrpsys)/build/hrpsys-base-source.

In catkin environment, hrpsys-base-source is located in
~/ros/hydro/build/rtm-ros-robotics/openrtm_common/hrpsys/build/hrpsys-base-source in my PC.
How can I get this kind of path in the generic way?

@k-okada
Copy link
Member

k-okada commented Jul 10, 2014

ls ${PWD/$(cd $(echo $CMAKE_PREFIX_PATH|cut -d\: -f1)/../src && pwd)/$(cd $(echo $CMAKE_PREFIX_PATH|cut -d\: -f1)/../build/ && pwd)/}/build/hrpsys-base-source

or you can check GIT_REVISION of Makefile.hrpsys-base

@snozawa
Copy link
Contributor Author

snozawa commented Jul 10, 2014

Thanks, I fixed the script.

snozawa added a commit that referenced this pull request Jul 15, 2014
@snozawa snozawa merged commit 8ba2d5f into start-jsk:master Jul 15, 2014
@snozawa snozawa mentioned this pull request Jul 15, 2014
shift
done

LATEST_DATE=$(grep -m1 .\\.*\\. $TARGET_DIRECTORY/CHANGELOG.rst | cut -d\( -f2 | cut -d\) -f1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snozawa, this line will not work on catkin environment, use rospack find hrpsys/CHANGELOG.rst, or
remove SUB_DIRECTORIES, but use something like TARGET_DIRECTORY and SOURCE_DIRECTORY

@130s
Copy link
Contributor

130s commented Aug 29, 2014

Quick fyi; there's also a discussion #109

@130s
Copy link
Contributor

130s commented Aug 29, 2014

And my plan (only in my mind) is to move release instruction from wiki to github (#109).

@snozawa snozawa deleted the add_script_for_changelog branch August 30, 2014 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants