Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use := instead of ?= #39

Closed
wants to merge 1 commit into from
Closed

use := instead of ?= #39

wants to merge 1 commit into from

Conversation

snozawa
Copy link
Contributor

@snozawa snozawa commented Mar 9, 2014

use ":=" instead of "?=",
because "?=" does not work if PKG_CONFIG_PATH exists and openrtm.pc or openhrp3.pc are not included in PKG_CONFIG_PATH

Currently, it seems not to work groovy+rosbuild environment.
If

source /opt/ros/groovy/setup.bash

is executed, PKG_CONFIG_PATH is as follow:

/opt/ros/groovy/lib/pkgconfig

…ts and openrtm.pc or openhrp3.pc are not included in PKG_CONFIG_PATH ;; I does not work groovy+rosbuild environment
@k-okada
Copy link
Member

k-okada commented Mar 9, 2014

Need travis test to check this
#40

@k-okada
Copy link
Member

k-okada commented Mar 10, 2014

please check again once #42, is merged.

I'm not sure what is the correct way, but I usually use
http://www.backlog.jp/git-guide/reference/log.html, or use git rebase -i HEAD~1 with reward command
(http://www.backlog.jp/git-guide/stepup/stepup7_6.html)

k-okada added a commit that referenced this pull request Mar 14, 2014
- add test codes
- merge #39
- fix PKG_CONFIG_PATH before rostest
- use load_manifest for rosbuild
@k-okada
Copy link
Member

k-okada commented Mar 14, 2014

Thanks for contribution, this patch was merged in #53

@k-okada k-okada closed this Mar 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants