Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make reqwest optional dep #979

Merged
merged 1 commit into from
Mar 5, 2020
Merged

feat: make reqwest optional dep #979

merged 1 commit into from
Mar 5, 2020

Conversation

davidkna
Copy link
Member

@davidkna davidkna commented Mar 5, 2020

Description

reqwest is a heavy dependency and not essential to starship thus gate it behind a http feature.

Motivation and Context

Closes #977

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

matchai
matchai approved these changes Mar 5, 2020
View reviewed changes
Copy link
Member

@matchai matchai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible to me. 👍
I can see this being particularly useful for nushell, if they don't already have reqwest.

Thank you for your PR! 😊

@matchai matchai merged commit d894ef5 into starship:master Mar 5, 2020
@samyakb samyakb mentioned this pull request Mar 12, 2020
Merged
8 tasks
dagbrown pushed a commit to dagbrown/starship that referenced this pull request Oct 22, 2021
@matchai @dagbrown
feat: make reqwest an optional dependency (starship#979)
8f79f2d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matchai matchai matchai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reqwest as an optional dependency
2 participants
@davidkna @matchai