Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Correct summary of git_commit module #737

Merged
merged 1 commit into from
Dec 16, 2019
Merged

docs: Correct summary of git_commit module #737

merged 1 commit into from
Dec 16, 2019

Conversation

ybc37
Copy link
Contributor

@ybc37 ybc37 commented Dec 15, 2019

Description

The summary of the git_commit module is wrong. I guess it was copied from the git_branch module, but wasn't adapted.

Motivation and Context

Documentation of git_commit was misleading.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@matchai matchai merged commit 40d4dab into starship:master Dec 16, 2019
@matchai
Copy link
Member

matchai commented Dec 16, 2019

Thank you for the fix @nesmyslny! 🙏😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andytom andytom andytom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ybc37 @matchai @andytom