fix: multiple batteries support in the battery module #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matchai
reviewed
Nov 25, 2019
There was a problem hiding this comment.
Looks good, @lucarin91!
Just a few comments before we can get this merged in. 😊
lucarin91
force-pushed
the
multiple-batteries
branch
from
2b514e0 to
6aa34bc
Compare
matchai
approved these changes
Dec 3, 2019
matchai
changed the title
|
Thank you for your contribution, Luca! 😄 @all-contributors Please add @lucarin91 for code. 🎉 |
|
I've put up a pull request to add @lucarin91! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I update the battery module, in order to implement an aggregating view of all the batteries present in the notebook.
The percentage of the battery is calculated with a weighted average of the energy of all the batteries. Instead, the battery state is calculated with the following rule:
Motivation and Context
As stated in issue #656 if there are multiple batteries in the notebook the battery module gives inconsistent values of the battery percentage and state.
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?
I test it on my Lenovo T450s that has two batteries. For now, there is not any unit test on the battery module.
Checklist: