Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update required Rust version to v1.38 #592

Merged
merged 1 commit into from
Oct 26, 2019
Merged

docs: Update required Rust version to v1.38 #592

merged 1 commit into from
Oct 26, 2019

Conversation

jugmac00
Copy link
Contributor

@jugmac00 jugmac00 commented Oct 25, 2019

Starship could not be built any more with Rust 1.36.

Now, the most recent version 1.38 is recommended.

This closes #591.

modified: README.md
modified: docs/README.md
modified: docs/de-DE/README.md
modified: docs/de-DE/guide/README.md
modified: docs/fr-FR/README.md
modified: docs/fr-FR/guide/README.md
modified: docs/ja-JP/README.md
modified: docs/ja-JP/guide/README.md
modified: docs/ru-RU/README.md
modified: docs/ru-RU/guide/README.md
modified: docs/zh-CN/README.md
modified: docs/zh-CN/guide/README.md
modified: docs/zh-TW/README.md
modified: docs/zh-TW/guide/README.md

Description

Update recommended version of Rust to 1.38 - was 1.33 before.

Motivation and Context

Closes #591

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

Starship could not be built any more with Rust 1.36.

Now, the most recent version 1.38 is recommended.

This closes #591.

modified:   README.md
modified:   docs/README.md
modified:   docs/de-DE/README.md
modified:   docs/de-DE/guide/README.md
modified:   docs/fr-FR/README.md
modified:   docs/fr-FR/guide/README.md
modified:   docs/ja-JP/README.md
modified:   docs/ja-JP/guide/README.md
modified:   docs/ru-RU/README.md
modified:   docs/ru-RU/guide/README.md
modified:   docs/zh-CN/README.md
modified:   docs/zh-CN/guide/README.md
modified:   docs/zh-TW/README.md
modified:   docs/zh-TW/guide/README.md
@jugmac00 jugmac00 changed the title Update recommendation for Rust version. Documentation: Update recommendation for Rust version. Oct 25, 2019
@jugmac00 jugmac00 changed the title Documentation: Update recommendation for Rust version. docs: Update recommendation for Rust version. Oct 25, 2019
Copy link
Member

@matchai matchai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍
As a heads up for next time, only the English docs have to be updated.
Crowdin will automatically update the docs for all other languages automatically.

@matchai matchai changed the title docs: Update recommendation for Rust version. docs: Update required Rust version to v1.38 Oct 26, 2019
@matchai matchai merged commit 59148ac into starship:master Oct 26, 2019
@jugmac00
Copy link
Contributor Author

@matchai Thank you for the time to review my pr and merge it.

Also thanks for the note about "crowdin" - I obviously have not used it before.

From other projects I am used to GNU gettext. Of course I thought there must be some mechanism for translation, but as I did not see any placeholders, I gave up and filed the pr anyway :-)

Next time I'll dig deeper and read up on these new translation tools.

hoop33 pushed a commit to hoop33/starship that referenced this pull request Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot install starship via cargo
2 participants