-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vlang): create module #2577
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following the precedent established by golang let's use vlang instead. Leaving that aside, good job @Milo123459 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
V uses v.mod
files following Go's go.mod
approach. @Milo123459 do a quick investigation to find out whether there are additional package management related files with v.sum
being a likely candidate.
Co-authored-by: Dario Vladović <[email protected]>
Co-authored-by: Dario Vladović <[email protected]>
Co-authored-by: Dario Vladović <[email protected]>
Co-authored-by: Dario Vladović <[email protected]>
Question, does detect_extensions have to always have that, but also have all the required files? |
May as well add a version system for V. |
If any of the conditions are met module will get displayed so it is OR rather than AND. |
Now I lost you. What do you mean by version system? |
I updated the package module to display the V version if v.mod is present. |
Co-authored-by: Dario Vladović <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Co-authored-by: David Knaack <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Milo123459 Please apply this patch https://github.com/vladimyr/starship/commit/8dcd68f.patch
So I'm changing the vlang config to v? I don't know why but sure |
Honestly, this is not my invention 🙃 There is already a Go module that sets precedent by having |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Milo123459 Once again thanks for your patience and hard work!
LGTM 🚀
Anything else need to change? |
Thank you for your contribution @Milo123459 and thank you for reviewing @vladimyr and @davidkna |
Description
Adds a module to display the currently installed V version
Motivation and Context
Closes #
Screenshots (if appropriate):
How Has This Been Tested?
Checklist: