Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(battery): add space between icon and text for better visual #2547

Merged
merged 2 commits into from
Apr 3, 2021

Conversation

vladimyr
Copy link
Member

@vladimyr vladimyr commented Apr 3, 2021

Description

Add space between battery symbol and charge percentage.

Motivation and Context

Original motivation:

We should unify the visual in Starship.

This is essentially repurposed @LitoMore's work with changes @davidkna suggested: #2333 (comment)
Closes #2333

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@vladimyr vladimyr requested a review from a team April 3, 2021 01:51
Copy link
Member

@andytom andytom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but do we also need to update the English version of the docs?

@vladimyr
Copy link
Member Author

vladimyr commented Apr 3, 2021

LGTM but do we also need to update the English version of the docs?

Indeed, totally forgot about that. Thanks for reminding me!

@LitoMore
Copy link
Contributor

LitoMore commented Apr 3, 2021

@vladimyr Thank you for continuing on my work.

@andytom andytom merged commit e19f79b into starship:master Apr 3, 2021
@andytom
Copy link
Member

andytom commented Apr 3, 2021

Thank you @LitoMore and @vladimyr.

@vladimyr vladimyr deleted the battery branch April 3, 2021 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants