Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update vulnerable generic-array package #2412

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

davidkna
Copy link
Member

@davidkna davidkna commented Mar 4, 2021

Description

This PR updates the vulnerable generic-array (0.12.3) package to 0.12.4.

Motivation and Context

Closes #2396

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@davidkna davidkna requested a review from a team March 4, 2021 16:21
@chipbuster
Copy link
Contributor

The cargo book says that Cargo.lock shouldn't be manually edited, but doesn't give convincing reasons as to why (same with a quick google search). Do you know why they recommend against it?

Copy link
Contributor

@chipbuster chipbuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a one-off fix, this looks fine. I do want to eventually know why the cargo authors seem to recommend against doing this though.

@davidkna
Copy link
Member Author

davidkna commented Mar 4, 2021

This isn't a manual edit, but cargo update -p generic-array.

@davidkna davidkna merged commit 7120611 into starship:master Mar 4, 2021
@davidkna davidkna deleted the fix-generic-array branch March 4, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RUSTSEC-2020-0146: arr! macro erases lifetimes
2 participants