-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(python): Handle PyPy python version correctly #2374
Conversation
Maybe the PyPy version should also be specified so that the output is |
I think this is fine as it is. The prompt already gets long enough without us trying to specify every single piece of version information--we can add a feature later to specify the exact python interpreter if needed, but that should probably be a separate feature PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tyilo You did a fine job ensuring PyPy version gets correctly formatted applying minimal changes to the existing codebase but let's please improve the complete Python version extraction & formatting logic instead.
To help you with that here is a patch for you to apply: https://github.com/vladimyr/starship/commit/34b0302.patch (as seen here vladimyr@34b0302)
Align Python version retrieval and formatting with established Starship conventions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Well done @tyilo!
Description
Add support for parsing PyPy python version.
Motivation and Context
Before this fix, I get the following prompt:
With the fix:
How Has This Been Tested?
Checklist: