Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(init): Quote path for elvish init #2294

Merged
merged 1 commit into from
Feb 13, 2021
Merged

fix(init): Quote path for elvish init #2294

merged 1 commit into from
Feb 13, 2021

Conversation

tgrelka
Copy link
Contributor

@tgrelka tgrelka commented Feb 11, 2021

Description

Added quotes to the init function string of elvish shell.

Motivation and Context

Closes #2293

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

Notes:

This has been a simple edit I did directly in GitHub, I currently don’t have an environment to test this. I added excacty four characters, two escaped quotes, to the init string of elvish, this should not affect any code.

Copy link
Member

@davidkna davidkna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidkna davidkna merged commit 4813763 into starship:master Feb 13, 2021
@tgrelka tgrelka deleted the fix-elvish-init branch February 14, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elvish Init function not properly quoted
2 participants