Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix changelog generation #2267

Merged
merged 1 commit into from
Feb 5, 2021
Merged

ci: fix changelog generation #2267

merged 1 commit into from
Feb 5, 2021

Conversation

davidkna
Copy link
Member

@davidkna davidkna commented Feb 4, 2021

Description

This PR makes the changelog generator compile again.

Changes:

  • Update to go to 1.15
  • Pin git-chglog to 0.9.1 because 0.10.0 requires go 1.16 (unreleased) to build. To allow pinning git-chglog GO111MODULE needs to be set to on.
  • Remove -u because apparently it can cause issues

Motivation and Context

Closes #

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

andytom
andytom approved these changes Feb 4, 2021
View reviewed changes
Copy link
Member

@andytom andytom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matchai matchai merged commit edb17bc into starship:master Feb 5, 2021
@davidkna davidkna deleted the ci-fix-chglog branch March 26, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andytom andytom andytom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidkna @andytom @matchai