Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(lua): Lazy eval lua #2185

Merged
merged 3 commits into from
Jan 21, 2021
Merged

perf(lua): Lazy eval lua #2185

merged 3 commits into from
Jan 21, 2021

Conversation

Isokaeder
Copy link
Contributor

Description

Execute version for Lua Lazily and update format string

Motivation and Context

Relates to #2111

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@Isokaeder Isokaeder changed the title Lazy eval lua perf(lua): Lazy eval lua Jan 21, 2021
@andytom andytom mentioned this pull request Jan 21, 2021
Closed
25 tasks
andytom
andytom approved these changes Jan 21, 2021
View reviewed changes
Copy link
Member

@andytom andytom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andytom andytom merged commit 98b89b9 into starship:master Jan 21, 2021
@andytom
Copy link
Member

andytom commented Jan 21, 2021

Thanks for your contribution @HansAuger .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andytom andytom andytom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Isokaeder @andytom