Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(git_branch): show remote name #1972

Merged

Conversation

sagittarius-a
Copy link
Contributor

Description

Git Branch module now provides two variables for remote repository:

  • remote_name: name of the remote (as set by git remote add command)
  • remote branch: name of the tracked branch on the remote

Motivation and Context

Closes #1971

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@mickimnet mickimnet changed the title Feature/git branch remote name feat(git branch): show remote name Dec 7, 2020
@mickimnet mickimnet changed the title feat(git branch): show remote name feat(git_branch): show remote name Dec 7, 2020
Copy link
Member

@andytom andytom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have added a quick suggestion but this LGTM in general

src/context.rs Outdated Show resolved Hide resolved
@andytom andytom merged commit d670212 into starship:master Dec 8, 2020
@andytom
Copy link
Member

andytom commented Dec 8, 2020

Thank you for the quick fixes @sagittarius-a

chipbuster pushed a commit to chipbuster/starship that referenced this pull request Jan 14, 2021
* feat(git_branch): Show remote name in addition to remote branch

* feat(git_branch): Fix table indentation in config README

* feat(git_branch): Use a different method to fetch remote information

* feat(git_branch): Fix the Clippy issue regarding string constant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Git Branch] Show Git remote name
2 participants