fix: replace emoji for CMake and Erlang with NerdFonts #1787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matchai
changed the title
|
Thank you @matchai! |
ghost
approved these changes
Oct 13, 2020
|
Ha, this is why my cpp project show chinese character "喝" ("drink") in prompt. |
|
Hi, "喝" in Chinese means "drink", "喝" as CMake project symbol is really weird to me, a Chinese native speaker. |
|
The character occupies the same Unicode codepoint as the symbol we are aiming to use in the Nerd Fonts version of fonts. If you are seeing the Chinese character for "drink" try changing your current font to a Nerd Font patched version. |
|
This PR break the prompt for Japanese too. I think this have better to be reverted.
|
|
@mattn, @DCjanus |
chipbuster
pushed a commit
to chipbuster/starship
that referenced
this pull request
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The emoji used for the CMake and Erlang modules appear to have little font support, as is shown on the emojipedia entries for the respective emoji:
https://emojipedia.org/triangle-with-rounded-corners/
https://emojipedia.org/three-networked-computers/
This PR replaces the emoji used with NerdFont icons for "Triangle Outline" and "Erlang".
Motivation and Context
Closes #
Screenshots (if appropriate):
How Has This Been Tested?
Checklist: