Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix latest clippy suggestions #1136

Merged
merged 1 commit into from
Apr 24, 2020
Merged

fix: Fix latest clippy suggestions #1136

merged 1 commit into from
Apr 24, 2020

Conversation

andytom
Copy link
Member

@andytom andytom commented Apr 24, 2020

Description

Have removed some imports that Clippy says are not needed anymore.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@andytom
Fix latest clippy suggestions
31b30bc 
Have removed some imports that Clippy says are not needed anymore.
@andytom andytom requested a review from a team April 24, 2020 09:11
@andytom andytom marked this pull request as ready for review April 24, 2020 09:23
@andytom andytom mentioned this pull request Apr 24, 2020
Merged
johnletey
johnletey approved these changes Apr 24, 2020
View reviewed changes
Copy link
Contributor

@johnletey johnletey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andytom Thanks for working on this 🎉 I was running into these issues in #1137

Let's merge this 🚀

@andytom andytom merged commit 060689f into starship:master Apr 24, 2020
@andytom andytom deleted the fix/new_clippy_suggestions branch April 24, 2020 10:37
dagbrown pushed a commit to dagbrown/starship that referenced this pull request Oct 22, 2021
@andytom @dagbrown
fix: Fix latest clippy suggestions (starship#1136)
d7b064b 
Have removed some imports that Clippy says are not needed anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnletey johnletey johnletey approved these changes

@heyrict heyrict heyrict approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andytom @heyrict @johnletey