Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add more detailed logging for executing cmds #1097

Merged
merged 1 commit into from
Apr 13, 2020

Conversation

andytom
Copy link
Member

@andytom andytom commented Apr 13, 2020

Description

This makes some changes to the logging to make debugging what is
happening a bit easier when we run external commands.

Motivation and Context

I was trying to debug some changes I was making locally and found it
useful to have the full details of what happened rather than just when
the command failed. Since this mght be useful to others I've added it
here.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

This makes some changes to the logging to make debugging what is
happening a bit easier when we run external commands.
Copy link
Contributor

@johnletey johnletey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@andytom andytom merged commit 05e323d into starship:master Apr 13, 2020
@andytom andytom deleted the chore/update_exec_cmd_logging branch April 13, 2020 13:22
dagbrown pushed a commit to dagbrown/starship that referenced this pull request Oct 22, 2021
This makes some changes to the logging to make debugging what is
happening a bit easier when we run external commands.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants