Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: split transaction file part one fields dedicated file #1732

Merged
merged 2 commits into from
Nov 11, 2024

chore: remove public imports from starknet api transaction

0985260
Select commit
Loading
Failed to load commit list.
Merged

chore: split transaction file part one fields dedicated file #1732

chore: remove public imports from starknet api transaction
0985260
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 11, 2024 in 0s

62.30% (+22.19%) compared to e3165c4

View this Pull Request on Codecov

62.30% (+22.19%) compared to e3165c4

Details

Codecov Report

Attention: Patch coverage is 68.12227% with 73 lines in your changes missing coverage. Please review.

Project coverage is 62.30%. Comparing base (e3165c4) to head (0985260).
Report is 293 commits behind head on main.

Files with missing lines Patch % Lines
crates/starknet_api/src/transaction/fields.rs 68.46% 58 Missing and 12 partials ⚠️
crates/native_blockifier/src/py_transaction.rs 0.00% 2 Missing ⚠️
crates/papyrus_rpc/src/v0_8/transaction.rs 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #1732       +/-   ##
===========================================
+ Coverage   40.10%   62.30%   +22.19%     
===========================================
  Files          26      331      +305     
  Lines        1895    35631    +33736     
  Branches     1895    35631    +33736     
===========================================
+ Hits          760    22200    +21440     
- Misses       1100    11544    +10444     
- Partials       35     1887     +1852

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov