-
Notifications
You must be signed in to change notification settings - Fork 490
/
diagnostics.rs
344 lines (307 loc) · 11.5 KB
/
diagnostics.rs
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
use std::fmt;
use std::hash::Hash;
use std::sync::Arc;
use cairo_lang_debug::debug::DebugWithDb;
use cairo_lang_filesystem::db::{get_originating_location, FilesGroup};
use cairo_lang_filesystem::ids::FileId;
use cairo_lang_filesystem::span::TextSpan;
use cairo_lang_utils::Upcast;
use itertools::Itertools;
use crate::error_code::{ErrorCode, OptionErrorCodeExt};
use crate::location_marks::get_location_marks;
#[cfg(test)]
#[path = "diagnostics_test.rs"]
mod test;
/// The severity of a diagnostic.
#[derive(Eq, PartialEq, Hash, Ord, PartialOrd, Clone, Copy, Debug)]
pub enum Severity {
Error,
Warning,
}
impl fmt::Display for Severity {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
match self {
Severity::Error => write!(f, "error"),
Severity::Warning => write!(f, "warning"),
}
}
}
/// A trait for diagnostics (i.e., errors and warnings) across the compiler.
/// Meant to be implemented by each module that may produce diagnostics.
pub trait DiagnosticEntry: Clone + fmt::Debug + Eq + Hash {
type DbType: Upcast<dyn FilesGroup> + ?Sized;
fn format(&self, db: &Self::DbType) -> String;
fn location(&self, db: &Self::DbType) -> DiagnosticLocation;
fn notes(&self, _db: &Self::DbType) -> &[DiagnosticNote] {
&[]
}
fn severity(&self) -> Severity {
Severity::Error
}
fn error_code(&self) -> Option<ErrorCode> {
None
}
/// Returns true if the two should be regarded as the same kind when filtering duplicate
/// diagnostics.
fn is_same_kind(&self, _other: &Self) -> bool;
// TODO(spapini): Add a way to inspect the diagnostic programmatically, e.g, downcast.
}
// The representation of a source location inside a diagnostic.
#[derive(Clone, Debug, Eq, Hash, PartialEq)]
pub struct DiagnosticLocation {
pub file_id: FileId,
pub span: TextSpan,
}
impl DiagnosticLocation {
/// Get the location of right after this diagnostic's location (with width 0).
pub fn after(&self) -> Self {
Self { file_id: self.file_id, span: self.span.after() }
}
/// Get the location of the originating user code.
pub fn user_location(&self, db: &dyn FilesGroup) -> Self {
let (file_id, span) = get_originating_location(db, self.file_id, self.span);
Self { file_id, span }
}
}
impl DebugWithDb<dyn FilesGroup> for DiagnosticLocation {
fn fmt(&self, f: &mut fmt::Formatter<'_>, db: &dyn FilesGroup) -> fmt::Result {
let user_location = self.user_location(db);
let file_path = user_location.file_id.full_path(db);
let marks = get_location_marks(db, &user_location);
let pos = match user_location.span.start.position_in_file(db, user_location.file_id) {
Some(pos) => format!("{}:{}", pos.line + 1, pos.col + 1),
None => "?".into(),
};
write!(f, "{file_path}:{pos}\n{marks}")
}
}
/// A note about a diagnostic.
/// May include a relevant diagnostic location.
#[derive(Clone, Debug, Eq, Hash, PartialEq)]
pub struct DiagnosticNote {
pub text: String,
pub location: Option<DiagnosticLocation>,
}
impl DiagnosticNote {
pub fn text_only(text: String) -> Self {
Self { text, location: None }
}
pub fn with_location(text: String, location: DiagnosticLocation) -> Self {
Self { text, location: Some(location) }
}
}
impl DebugWithDb<dyn FilesGroup> for DiagnosticNote {
fn fmt(&self, f: &mut fmt::Formatter<'_>, db: &(dyn FilesGroup + 'static)) -> fmt::Result {
write!(f, "{}", self.text)?;
if let Some(location) = &self.location {
write!(f, ":\n --> ")?;
location.user_location(db).fmt(f, db)?;
}
Ok(())
}
}
/// This struct is used to ensure that when an error occurs, a diagnostic is properly reported.
///
/// It must not be constructed directly. Instead, it is returned by [DiagnosticsBuilder::add]
/// when a diagnostic is reported.
#[derive(Clone, Copy, Debug, Default, Eq, Hash, PartialEq)]
pub struct DiagnosticAdded;
pub fn skip_diagnostic() -> DiagnosticAdded {
// TODO(lior): Consider adding a log here.
DiagnosticAdded
}
/// Represents an arbitrary type T or a missing output due to an error whose diagnostic was properly
/// reported.
pub type Maybe<T> = Result<T, DiagnosticAdded>;
/// Temporary trait to allow conversions from the old `Option<T>` mechanism to `Maybe<T>`.
// TODO(lior): Remove this trait after converting all the functions.
pub trait ToMaybe<T> {
fn to_maybe(self) -> Maybe<T>;
}
impl<T> ToMaybe<T> for Option<T> {
fn to_maybe(self) -> Maybe<T> {
match self {
Some(val) => Ok(val),
None => Err(skip_diagnostic()),
}
}
}
/// Temporary trait to allow conversions from `Maybe<T>` to `Option<T>`.
/// The behavior is identical to [Result::ok]. It is used to mark all the location where there
/// is a conversion between the two mechanisms.
// TODO(lior): Remove this trait after converting all the functions.
pub trait ToOption<T> {
fn to_option(self) -> Option<T>;
}
impl<T> ToOption<T> for Maybe<T> {
fn to_option(self) -> Option<T> {
self.ok()
}
}
/// A builder for Diagnostics, accumulating multiple diagnostic entries.
#[derive(Clone, Debug, Eq, Hash, PartialEq)]
pub struct DiagnosticsBuilder<TEntry: DiagnosticEntry> {
pub error_count: usize,
pub leaves: Vec<TEntry>,
pub subtrees: Vec<Diagnostics<TEntry>>,
}
impl<TEntry: DiagnosticEntry> DiagnosticsBuilder<TEntry> {
pub fn add(&mut self, diagnostic: TEntry) -> DiagnosticAdded {
if diagnostic.severity() == Severity::Error {
self.error_count += 1;
}
self.leaves.push(diagnostic);
DiagnosticAdded
}
pub fn extend(&mut self, diagnostics: Diagnostics<TEntry>) {
self.error_count += diagnostics.0.error_count;
self.subtrees.push(diagnostics);
}
pub fn build(self) -> Diagnostics<TEntry> {
Diagnostics(self.into())
}
}
impl<TEntry: DiagnosticEntry> From<Diagnostics<TEntry>> for DiagnosticsBuilder<TEntry> {
fn from(diagnostics: Diagnostics<TEntry>) -> Self {
let mut new_self = Self::default();
new_self.extend(diagnostics);
new_self
}
}
impl<TEntry: DiagnosticEntry> Default for DiagnosticsBuilder<TEntry> {
fn default() -> Self {
Self { leaves: Default::default(), subtrees: Default::default(), error_count: 0 }
}
}
pub fn format_diagnostics(
db: &(dyn FilesGroup + 'static),
message: &str,
location: DiagnosticLocation,
) -> String {
format!("{message}\n --> {:?}\n", location.debug(db))
}
#[derive(Debug)]
pub struct FormattedDiagnosticEntry {
severity: Severity,
error_code: Option<ErrorCode>,
message: String,
}
impl FormattedDiagnosticEntry {
pub fn new(severity: Severity, error_code: Option<ErrorCode>, message: String) -> Self {
Self { severity, error_code, message }
}
pub fn is_empty(&self) -> bool {
self.message().is_empty()
}
pub fn severity(&self) -> Severity {
self.severity
}
pub fn error_code(&self) -> Option<ErrorCode> {
self.error_code
}
pub fn message(&self) -> &str {
&self.message
}
}
impl fmt::Display for FormattedDiagnosticEntry {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
write!(
f,
"{severity}{code}: {message}",
severity = self.severity,
message = self.message,
code = self.error_code.display_bracketed()
)
}
}
/// A set of diagnostic entries that arose during a computation.
#[derive(Clone, Debug, Eq, Hash, PartialEq)]
pub struct Diagnostics<TEntry: DiagnosticEntry>(pub Arc<DiagnosticsBuilder<TEntry>>);
impl<TEntry: DiagnosticEntry> Diagnostics<TEntry> {
pub fn new() -> Self {
Self(DiagnosticsBuilder::default().into())
}
/// Returns Ok if there are no errors, or DiagnosticAdded if there are.
pub fn check_error_free(&self) -> Maybe<()> {
if self.0.error_count == 0 { Ok(()) } else { Err(DiagnosticAdded) }
}
/// Format entries to pairs of severity and message.
pub fn format_with_severity(&self, db: &TEntry::DbType) -> Vec<FormattedDiagnosticEntry> {
let mut res: Vec<FormattedDiagnosticEntry> = Vec::new();
let files_db = db.upcast();
for entry in &self.get_diagnostics_without_duplicates(db) {
let mut msg = String::new();
msg += &format_diagnostics(files_db, &entry.format(db), entry.location(db));
for note in entry.notes(db) {
msg += &format!("note: {:?}\n", note.debug(files_db))
}
msg += "\n";
let formatted =
FormattedDiagnosticEntry::new(entry.severity(), entry.error_code(), msg);
res.push(formatted);
}
res
}
/// Format entries to a [`String`] with messages prefixed by severity.
pub fn format(&self, db: &TEntry::DbType) -> String {
self.format_with_severity(db).iter().map(ToString::to_string).join("")
}
/// Asserts that no diagnostic has occurred, panicking with an error message on failure.
pub fn expect(&self, error_message: &str) {
assert!(self.0.leaves.is_empty(), "{error_message}\n{self:?}");
for subtree in &self.0.subtrees {
subtree.expect(error_message);
}
}
/// Same as [Self::expect], except that the diagnostics are formatted.
pub fn expect_with_db(&self, db: &TEntry::DbType, error_message: &str) {
assert!(self.0.leaves.is_empty(), "{}\n{}", error_message, self.format(db));
for subtree in &self.0.subtrees {
subtree.expect_with_db(db, error_message);
}
}
// TODO(spapini): This is temporary. Remove once the logic in language server doesn't use this.
/// Get all diagnostics.
pub fn get_all(&self) -> Vec<TEntry> {
let mut res = self.0.leaves.clone();
for subtree in &self.0.subtrees {
res.extend(subtree.get_all())
}
res
}
/// Get diagnostics without duplication.
///
/// Two diagnostics are considered duplicated if both point to
/// the same location in the user code, and are of the same kind.
pub fn get_diagnostics_without_duplicates(&self, db: &TEntry::DbType) -> Vec<TEntry> {
let diagnostic_with_dup = self.get_all();
if diagnostic_with_dup.is_empty() {
return diagnostic_with_dup;
}
let files_db = db.upcast();
let indexed_dup_diagnostic = diagnostic_with_dup
.iter()
.enumerate()
.sorted_by_key(|(idx, diag)| (diag.location(db).user_location(files_db).span, *idx));
let mut prev_diagnostic_indexed: Option<(usize, &TEntry)> = None;
let mut diagnostic_without_dup = Vec::new();
for diag in indexed_dup_diagnostic {
if prev_diagnostic_indexed.is_some()
&& prev_diagnostic_indexed.unwrap().1.is_same_kind(diag.1)
&& prev_diagnostic_indexed.unwrap().1.location(db).user_location(files_db).span
== diag.1.location(db).user_location(files_db).span
{
continue;
}
diagnostic_without_dup.push(diag);
prev_diagnostic_indexed = Some(diag);
}
diagnostic_without_dup.sort_by_key(|(idx, _)| *idx);
diagnostic_without_dup.into_iter().map(|(_, diag)| diag.clone()).collect()
}
}
impl<TEntry: DiagnosticEntry> Default for Diagnostics<TEntry> {
fn default() -> Self {
Self::new()
}
}