Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to choose ip and port in cairo-run --tracer #126

Open
choideugene opened this issue Nov 28, 2022 · 1 comment · May be fixed by #161
Open

Allow user to choose ip and port in cairo-run --tracer #126

choideugene opened this issue Nov 28, 2022 · 1 comment · May be fixed by #161

Comments

@choideugene
Copy link

Hi! I use a custom docker image to build and run cairo files. Today, cairo-run ... --tracer uses localhost to host the tracer ui. This unfortunately means that I cannot properly forward traffic from my host to the container. A simple fix would be to replace localhost with 0.0.0.0 at this line

However, maybe we can generalize and allow the user to choose the ip and port on which the tracer ui is hosted. For example, maybe

cairo-run ... --tracer --tracer-ip 0.0.0.0 --tracer-port 8101
@halseth halseth linked a pull request Apr 26, 2023 that will close this issue
@halseth
Copy link

halseth commented Apr 28, 2023

@choideugene I made an attempt at fixing this here: #161

Feel free to test if it works for you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants