Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abi parser Cario1 Version2 #665

Merged
merged 6 commits into from
Jul 3, 2023
Merged

abi parser Cario1 Version2 #665

merged 6 commits into from
Jul 3, 2023

Conversation

tabaktoni
Copy link
Collaborator

@tabaktoni tabaktoni commented Jun 30, 2023

Motivation and Resolution

The quick implementation is only essential for parser v2, and will need to be refactored later
Tests for Cairo1 Version 2 - All expected to pass, pass (fail 2d array test on the same nonce issue)

create separate classes for abi parsing based on abi version true same interface and factory class.
extract existing parsing from implementations on CallData and Cairo into the parser.

Checklist:

  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Linked the issues which this PR resolves
  • Documented the changes in code (API docs will be generated automatically)
  • Updated the tests
  • All tests are passing

@netlify
Copy link

netlify bot commented Jun 30, 2023

Deploy Preview for starknetjs canceled.

Name Link
🔨 Latest commit 03ee060
🔍 Latest deploy log https://app.netlify.com/sites/starknetjs/deploys/64a2dc40b46aaa000812ec34

@tabaktoni tabaktoni changed the title [WIP] abi parser abi parser Cario1 Version2 Jul 3, 2023
@tabaktoni tabaktoni marked this pull request as ready for review July 3, 2023 12:40
Copy link
Collaborator

@penovicp penovicp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general lgtm, there are some simple lint errors that will prevent the CI from running successfully so those should be resolved before merging.

src/utils/calldata/parser/parser-2.0.0.ts Outdated Show resolved Hide resolved
src/utils/calldata/parser/parser-0-1.1.0.ts Show resolved Hide resolved
src/utils/calldata/index.ts Outdated Show resolved Hide resolved
src/utils/calldata/index.ts Show resolved Hide resolved
src/utils/calldata/cairo.ts Show resolved Hide resolved
@tabaktoni tabaktoni requested a review from ivpavici July 3, 2023 14:34
@tabaktoni tabaktoni changed the base branch from develop to next-version July 3, 2023 14:34
@tabaktoni
Copy link
Collaborator Author

In general lgtm, there are some simple lint errors that will prevent the CI from running successfully so those should be resolved before merging.

Yea, also this will be forced merged as it relays on integration

@tabaktoni tabaktoni merged commit 589c948 into next-version Jul 3, 2023
@github-actions
Copy link

github-actions bot commented Jul 3, 2023

🎉 This PR is included in version 5.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Jul 18, 2023
# [5.17.0](v5.16.0...v5.17.0) (2023-07-18)

### Bug Fixes

* add FailedTransactionResponse ([994925e](994925e))
* remedy type declaration roll-up issues ([48625f4](48625f4))
* transaction_failure_reason ([77329b7](77329b7))

### Features

* add Enum in contract ([515e233](515e233)), closes [#670](#670) [#665](#665) [#664](#664) [#1](#1)
* calldata result in populate ([d44dc56](d44dc56)), closes [#675](#675) [#1](#1)
* contractFactory Cairo1 & changed constructor signature, 0.12 test fixes ([9b44c54](9b44c54))
* rename Failed to Rejected for transaction type ([65b1ef4](65b1ef4))
github-actions bot pushed a commit that referenced this pull request Aug 11, 2023
# [5.19.0](v5.18.0...v5.19.0) (2023-08-11)

### Bug Fixes

* add function definition to the contract interface + doc ([06498d5](06498d5))
* contract test status ([53cfaf9](53cfaf9))
* fix multiple same events + add cairo code + seperate tests, legacy and Cairo1 ([7c93157](7c93157))
* modify parseEvents structure + add testcase for multiple different event in same tx ([b63b0d6](b63b0d6))
* optional struct and enum in responseParser ([14d3cca](14d3cca))
* patch merge, and add enums to event parser ([00f8073](00f8073))
* remove exports from responseParser functions ([3d86446](3d86446))
* repair SequencerProvider network resolution ([e42dfc1](e42dfc1))
* restore package-lock to previous state ([2fe0564](2fe0564))

### Features

* add ethAddress handling ([2a93f90](2a93f90))
* cairo enum in request parser ([ad44481](ad44481))
* cairo enum in response parser ([a936a11](a936a11)), closes [#670](#670) [#665](#665) [#664](#664) [#1](#1) [#675](#675) [#1](#1) [#675](#675) [#1](#1) [#670](#670) [#665](#665) [#664](#664) [#1](#1) [#675](#675) [#1](#1)
* implement event parsing ([86cc430](86cc430))
* new Cairo types ([f9db09e](f9db09e))
@penovicp penovicp deleted the 0.12.0/abi-parser branch September 16, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants