Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check PENDING and LATEST block params #369

Closed
ivpavici opened this issue Oct 24, 2022 · 2 comments · Fixed by #670
Closed

Check PENDING and LATEST block params #369

ivpavici opened this issue Oct 24, 2022 · 2 comments · Fixed by #670
Assignees
@tabaktoni
Labels
waiting on StarkWare wontfix This will not be worked on

Comments

@ivpavici
Copy link
Collaborator

There are some problems when expecting the statuses of blocks in tests.

If there is no block status then LATEST is used, which can cause tests to fail
@ivpavici ivpavici added the Type: bug Something isn't working label Oct 24, 2022
@ivpavici
Copy link
Collaborator Author

Will be handled by StarkWare, on hold until then

@tabaktoni
Copy link
Collaborator

Starkware will remove the PENDING block in the future ( Starknet 0.13-0.14) so this issue will be resolved then

@tabaktoni tabaktoni added wontfix This will not be worked on and removed Type: bug Something isn't working labels Feb 22, 2023
@tabaktoni tabaktoni mentioned this issue Jul 3, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tabaktoni tabaktoni

Labels
waiting on StarkWare wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Next version starknet-io/starknet.js
2 participants
@tabaktoni @ivpavici