From 58c21c0a3c647eae781d57024c3193aa6c98b20b Mon Sep 17 00:00:00 2001
From: ivpavici <ivan.pavicic@live.com>
Date: Fri, 23 Sep 2022 20:16:58 +0200
Subject: [PATCH] fix: adapted transactionTrace response

---
 __tests__/sequencerProvider.test.ts |  2 +-
 src/types/api/sequencer.ts          | 25 +++++++++----------------
 www/docs/API/provider.md            | 20 ++++++++++++++------
 3 files changed, 24 insertions(+), 23 deletions(-)

diff --git a/__tests__/sequencerProvider.test.ts b/__tests__/sequencerProvider.test.ts
index 19d1bc941..fecc190b6 100644
--- a/__tests__/sequencerProvider.test.ts
+++ b/__tests__/sequencerProvider.test.ts
@@ -44,7 +44,7 @@ describeIfSequencer('SequencerProvider', () => {
 
     test('transaction trace', async () => {
       const transactionTrace = await sequencerProvider.getTransactionTrace(exampleTransactionHash);
-      expect(transactionTrace).toHaveProperty('function_invocation');
+      // TODO test optional properties
       expect(transactionTrace).toHaveProperty('signature');
     });
 
diff --git a/src/types/api/sequencer.ts b/src/types/api/sequencer.ts
index ab951db9f..d27e1ed90 100644
--- a/src/types/api/sequencer.ts
+++ b/src/types/api/sequencer.ts
@@ -27,15 +27,17 @@ export type GetContractAddressesResponse = {
   GpsStatementVerifier: string;
 };
 
-export type InvokeFunctionTrace = {
+export type FunctionInvocation = {
   caller_address: string;
   contract_address: string;
-  code_address: string;
-  selector: string;
   calldata: RawCalldata;
+  call_type?: string;
+  class_hash?: string;
+  selector?: string;
+  entry_point_type?: EntryPointType;
   result: Array<any>;
   execution_resources: ExecutionResources;
-  internal_call: Array<InvokeFunctionTrace>;
+  internal_calls: Array<FunctionInvocation>;
   events: Array<any>;
   messages: Array<any>;
 };
@@ -54,18 +56,9 @@ export type ExecutionResources = {
 };
 
 export type GetTransactionTraceResponse = {
-  function_invocation: {
-    caller_address: string;
-    contract_address: string;
-    code_address: string;
-    selector: string;
-    calldata: RawArgs;
-    result: Array<any>;
-    execution_resources: ExecutionResources;
-    internal_call: Array<any>;
-    events: Array<any>;
-    messages: Array<any>;
-  };
+  validate_invocation?: FunctionInvocation;
+  function_invocation?: FunctionInvocation;
+  fee_transfer_invocation?: FunctionInvocation;
   signature: Signature;
 };
 
diff --git a/www/docs/API/provider.md b/www/docs/API/provider.md
index 45b6b514c..47ec8fe8c 100644
--- a/www/docs/API/provider.md
+++ b/www/docs/API/provider.md
@@ -271,21 +271,29 @@ Gets the transaction trace from a tx hash.
 
 ```typescript
 {
-  function_invocation: {
+  validate_invocation?: FunctionInvocation;
+  function_invocation?: FunctionInvocation;
+  fee_transfer_invocation?: FunctionInvocation;
+  signature: Signature;
+}
+
+{
+  FunctionInvocation: {
     caller_address: string;
     contract_address: string;
-    code_address: string;
-    selector: string;
     calldata: {
       [inputName: string]: string | string[] | { type: 'struct'; [k: string]: BigNumberish };
     };
+    call_type?: string;
+    class_hash?: string;
+    selector?: string;
+    entry_point_type?: EntryPointType;
     result: Array<any>;
-    execution_resources: any;
-    internal_call: Array<any>;
+    execution_resources: ExecutionResources;
+    internal_calls: Array<FunctionInvocation>;
     events: Array<any>;
     messages: Array<any>;
   };
-  signature: Signature;
 }
 ```