This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 54
fix(button): Update button to use semibold weight #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notandrew
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
February 1, 2019 19:51
codepretty
reviewed
Feb 2, 2019
kuzhelov
reviewed
Feb 4, 2019
kuzhelov
added
needs author feedback
Author's opinion is asked
and removed
🚀 ready for review
labels
Feb 5, 2019
codepretty
changed the title
updating button to use semibold weight
fix(button): Update button to use semibold weight
Feb 6, 2019
Codecov Report
@@ Coverage Diff @@
## master #829 +/- ##
=======================================
Coverage 80.57% 80.57%
=======================================
Files 651 651
Lines 8330 8330
Branches 1484 1420 -64
=======================================
Hits 6712 6712
Misses 1603 1603
Partials 15 15
Continue to review full report at Codecov.
|
notandrew
added
🚀 ready for review
and removed
needs author feedback
Author's opinion is asked
labels
Feb 7, 2019
mnajdova
reviewed
Feb 8, 2019
packages/react/src/themes/teams/components/Button/buttonVariables.ts
Outdated
Show resolved
Hide resolved
mnajdova
approved these changes
Feb 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update button text to be semibold instead of regular font weight. Fix #862
Before
After