This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(MenuDivider): not shown when used on horizontal menus #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnajdova
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason and
miroslavstastny
as code owners
kuzhelov
approved these changes
Jan 31, 2019
kuzhelov
reviewed
Jan 31, 2019
| divider: ({ props: { pointing, vertical, pills, underlined } }) => ({ | ||
| ...(pointing && | ||
| vertical && { | ||
| marginBottom: `${pxToRem(12)}`, |
There was a problem hiding this comment.
have agreed with @mnajdova to prevent duplication of pxToRem styles between MenuDivider and MenuItem styles
added 4 commits
January 31, 2019 22:12
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #722 The Divider is not shown on all menus, and the margins on different menus are fixed.