This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
feat(Icon): add chevron icons for expand/collapse #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nu as toolbar example
codepretty
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
kuzhelov
reviewed
Jan 29, 2019
| @@ -69,8 +69,7 @@ const items = [ | |||
| key: 'menuButton', | |||
| icon: { | |||
| name: 'more', | |||
| circular: true, | |||
| size: 'small', | |||
| variables: { outline: true }, | |||
kuzhelov
reviewed
Jan 29, 2019
| import { TeamsSvgIconSpec } from '../types' | ||
|
|
||
| export default { | ||
| icon: ({ classes }) => ( | ||
| <svg role="presentation" focusable="false" viewBox="8 8 16 16" className={classes.svg}> | ||
| <g className={classes.filledPart}> | ||
| <g className={cx('ui-icon__filled', classes.filledPart)}> |
There was a problem hiding this comment.
would suggest to introduce a constant variable for these class names, to ensure that the same value is used by all icons, as well as by menu's CSS selectors:
import { ThemeClasses } from 'themes/teams'
<g className={cx(ThemeClasses.iconFilled, classes.filledPart)} />Lets move it to a dedicated PR, though, as this one doesn't make this particular problem to be any worse.
kuzhelov
changed the title
kuzhelov
approved these changes
Jan 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two chevron icons are needed for expanding / collapsing control messages
I also did a quick fix on the menu toolbar more icon
Before
After
