This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(typings): synthetic event #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuzhelov
requested review from
dvdzkwsk,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
miroslavstastny
approved these changes
Jan 17, 2019
| @@ -31,7 +31,10 @@ export type ReactChildren = React.ReactNodeArray | React.ReactNode | |||
| export type ReactPropsStrict<T> = { [K in keyof T]: NullableIfUndefined<T[K]> } | |||
| export type ReactProps<T> = Extendable<ReactPropsStrict<T>> | |||
|
|
|||
| export type ComponentEventHandler<TProps> = (event: React.SyntheticEvent, data: TProps) => void | |||
| export type ComponentEventHandler<TProps> = ( | |||
There was a problem hiding this comment.
Suggested change
| export type ComponentEventHandler<TProps> = ( | |
| export type ComponentEventHandler<TProps, TElem = HTMLElement> = ( |
Can we make this a generic?
There was a problem hiding this comment.
yes, although not sure whether it is necessary to introduce this variability now, as it is pretty much clear that it will always be about HTMLElement for this handler's type - thus, not sure if we should make this type to be customizable (as it will, probably, will be an indication of some improper assumptions)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR explicitly specifies generic param (as
HTMLElement) of type that is used for synthetic event arg in component's event handlers.This is necessary for client libraries to avoid explicit cast from
Element(currently provided by Stardust) toHTMLElementwhich is expected by client's code.TODO