This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
refactor(Dropdown): rename DropdownLabel to DropdownSelectedItem #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
21 tasks
mnajdova
reviewed
Jan 15, 2019
|
|
||
| static create: Function | ||
|
|
||
| className = 'ui-dropdown__label' | ||
| static className = 'ui-dropdown__label' |
There was a problem hiding this comment.
let's rename the className as well
mnajdova
approved these changes
Jan 15, 2019
silviuaavram
approved these changes
Jan 15, 2019
mnajdova
reviewed
Jan 15, 2019
| @@ -17,6 +17,9 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm | |||
|
|
|||
| ## [Unreleased] | |||
|
|
|||
| ### Fixes | |||
| - Rename `DropdownLabel` to `DropdownSelectedItem` and extract styles @layershifter ([#725](https://github.com/stardust-ui/react/pull/725)) | |||
There was a problem hiding this comment.
Please before merging move this to BREAKING CHANGES.
There was a problem hiding this comment.
Yep, also added update notes 👍
…stardust-ui/react into refactor/dropdown-selectem-item
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #560.
BREAKING
staticfordisplayNameandclassNamehandleIconOverridesDropdownSelectedItemstyles to a separate fileBefore
dropdownStyles.tsAfter
dropdownSelectedItem.ts