Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

feat(slot): rename Slot to Box and export #713

Merged
merged 2 commits into from
Jan 18, 2019

Conversation

bmdalex
Copy link
Collaborator

@bmdalex bmdalex commented Jan 14, 2019

feat(slot): rename Slot to Box and export

Description

This PR:

  • renames internal Slot component to Box
  • export Box (former Slot)

Copy link
Contributor

@kuzhelov kuzhelov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving the PR as this rename has been agreed upon - but my personal feeling is that this move introduces even more misleading moments (have pointed a few in the PR) than we have before.

Also, this generic Component name doesn't provide any context on its semantics and where it should be used, in contrast to the former Slot name.

It would be great if we would wait for others' opinions before merging.

@kuzhelov kuzhelov added the question Further information is requested, concerns that require additional thought are raised label Jan 14, 2019
@bmdalex bmdalex force-pushed the feat/slot-component-renaming branch from 582d3dc to 75a8c90 Compare January 15, 2019 17:58
@bmdalex bmdalex changed the title feat(slot): rename Slot to Component and export feat(slot): rename Slot to Box and export Jan 15, 2019
@bmdalex bmdalex force-pushed the feat/slot-component-renaming branch from 75a8c90 to 11b1e7d Compare January 16, 2019 12:17
@bmdalex bmdalex added postponed Item is postponed and will be reconsidered in future and removed question Further information is requested, concerns that require additional thought are raised labels Jan 16, 2019
@bmdalex
Copy link
Collaborator Author

bmdalex commented Jan 16, 2019

Postponing until solving a dependency

@bmdalex bmdalex force-pushed the feat/slot-component-renaming branch from 11b1e7d to b1a857f Compare January 18, 2019 13:40
@bmdalex bmdalex removed the postponed Item is postponed and will be reconsidered in future label Jan 18, 2019
@bmdalex bmdalex merged commit 8ec13bf into master Jan 18, 2019
@bmdalex bmdalex deleted the feat/slot-component-renaming branch January 18, 2019 13:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants