This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
BREAKING: export all typings #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levithomason
requested review from
dvdzkwsk,
kuzhelov,
miroslavstastny and
mnajdova
as code owners
levithomason
force-pushed
the
feat/export-types
branch
from
b0ff9d6
to
db1f55c
Compare
Codecov Report
@@ Coverage Diff @@
## master #382 +/- ##
==========================================
+ Coverage 90.55% 90.77% +0.22%
==========================================
Files 67 41 -26
Lines 1334 1334
Branches 169 194 +25
==========================================
+ Hits 1208 1211 +3
+ Misses 123 120 -3
Partials 3 3
Continue to review full report at Codecov.
|
kuzhelov
approved these changes
Oct 22, 2018
kuzhelov
approved these changes
Oct 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exports all typings at the top level. This required a number of changes, including cleaning up our names and paths so that consumers have a more sane API to work with.
All components were also exported top level in the process, some were missing.
Refactor
theme/typings.ts(required to generate def files properly)Fixes
Fixed menu behavior examples
Fixed a lot of other issues necessary for refactors...