-
Notifications
You must be signed in to change notification settings - Fork 54
Conversation
a848e89
to
581eb94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ~80kB (unzipped). In the feature we should think about moving it to a separate package?
(Some of) the icons are broken
581eb94
to
82c7773
Compare
Codecov Report
@@ Coverage Diff @@
## master #211 +/- ##
=======================================
Coverage 90.17% 90.17%
=======================================
Files 55 55
Lines 916 916
Branches 142 142
=======================================
Hits 826 826
Misses 86 86
Partials 4 4
Continue to review full report at Codecov.
|
This size may have included typings and propTypes which shouldn't be part of the production bundle. However, I've removed the typings and propTypes for now. Themes will likely define their own icon names and icons. Until we resolve this, I don't think we should validate names. Yes, this should be included in a separate package in the future, maybe the
Fixed.
Fixed by relaxing the check to Just FYI, |
This is passing on Screener and works locally. I'm not sure why icons weren't loading for you locally. However, I also have I'm going to merge this PR adding icon names as is since it is passing and only adds the missing names to the existing pattern. I will then finish the merge themes fix before making a release. |
The reason is all the icons which do not work for me are from Font Awesome 5 Brands, not from Font Awesome 5 Free. |
Heads up, I've fixed brand icons as well now. |
This PR adds all Font Awesome icons to the style Map, Icon typings, and Icon propTypes. This unblocks some of our consumers right away. It is also something we'll keep in the future, perhaps in the
default
theme so we're not adding throw away work here.