Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix(Alert): correctly handle RTL if shorthand API is used #2018

Merged
merged 4 commits into from
Oct 9, 2019

Conversation

miroslavstastny
Copy link
Member

Fixes #2017
Set dir="auto" on Alert only if Children API is used.
If shorthand API is used, content is wrapped by its own Text component, no need to set dir on parent container.

@codecov
Copy link

codecov bot commented Oct 9, 2019

Codecov Report

Merging #2018 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2018   +/-   ##
======================================
  Coverage    75.8%   75.8%           
======================================
  Files         160     160           
  Lines        5572    5572           
  Branches     1631    1614   -17     
======================================
  Hits         4224    4224           
  Misses       1334    1334           
  Partials       14      14
Impacted Files Coverage Δ
packages/react/src/components/Alert/Alert.tsx 80% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f234425...dc0aa3d. Read the comment docs.

@miroslavstastny miroslavstastny added the 🧰 fix Introduces fix for broken behavior. label Oct 9, 2019
@miroslavstastny miroslavstastny merged commit 2f6c821 into master Oct 9, 2019
@miroslavstastny miroslavstastny deleted the fix/alert-rtl branch October 9, 2019 19:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🧰 fix Introduces fix for broken behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alert component doesn't render RTL order correctly
3 participants